Slow performance when first loading a repository #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NSMutableSet makes sure the added objectes are unique.
ghost
changed the title
ghost
mentioned this pull request
Isn’t that the entire reason for using a Set instead of an Array in the first place? 👍 |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My repository has about 20k commits, but a lot of tags and branches. 1964 takes over 10 seconds to load it (on a Mac Pro), this change brings it back to about 1s, on par with 1899 (I think it's still slightly slower, but it doesn't bother me enough to measure it more accurately).
This was introduced in 65a0c10.
There is no need to check if items are in a set before adding them, because NSMutableSet already makes sure the added objectes are unique (see
-[NSMutableSet addObject:]docs).